Smoke may repel some attackers, however, more serious defensive weapons are desirable.
But, you may be right, some felons would not carry socially unacceptable killing machines.
I happen to live in a community where handguns are socially acceptable for self-defense.